|
Hi all,
I recently ran into the need to define a custom MillisProvider for test purposes. Full explanation for this use case can be found here: http://passion.forco.de/content/beware-now-equals-now-might-yield-false I have two wishes / feature requests: - please make DateTimeUtils.MillisProvider a public interface - add a method setMillisProvider, which allows to set a custom millis povider implementation Any chances to see these features in one of the upcoming joda time releases? I'd also be willing to help out with coding... Kind regards Ansgar Konermann ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
Please check the latest svn code. It should handle your requirement.
Stephen On 23 June 2010 20:05, Ansgar Konermann <[hidden email]> wrote: > Hi all, > > I recently ran into the need to define a custom MillisProvider for test > purposes. > > Full explanation for this use case can be found here: > http://passion.forco.de/content/beware-now-equals-now-might-yield-false > > I have two wishes / feature requests: > - please make DateTimeUtils.MillisProvider a public interface > - add a method setMillisProvider, which allows to set a custom millis > povider implementation > > Any chances to see these features in one of the upcoming joda time > releases? I'd also be willing to help out with coding... > > Kind regards > > Ansgar Konermann > > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Joda-interest mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/joda-interest > ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
Hi Stephen,
great! Thanks. Do you plan on making a release any time soon, or is it worth the effort to build the source code on my own and deploy it into our company's maven repo? Best regards Ansgar On 24.06.2010 12:21, Stephen Colebourne wrote: > Please check the latest svn code. It should handle your requirement. > Stephen > > On 23 June 2010 20:05, Ansgar Konermann<[hidden email]> wrote: > >> Hi all, >> >> I recently ran into the need to define a custom MillisProvider for test >> purposes. >> >> Full explanation for this use case can be found here: >> http://passion.forco.de/content/beware-now-equals-now-might-yield-false >> >> I have two wishes / feature requests: >> - please make DateTimeUtils.MillisProvider a public interface >> - add a method setMillisProvider, which allows to set a custom millis >> povider implementation >> >> Any chances to see these features in one of the upcoming joda time >> releases? I'd also be willing to help out with coding... >> >> Kind regards >> >> Ansgar Konermann >> >> ------------------------------------------------------------------------------ >> ThinkGeek and WIRED's GeekDad team up for the Ultimate >> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the >> lucky parental unit. See the prize list and enter to win: >> http://p.sf.net/sfu/thinkgeek-promo >> _______________________________________________ >> Joda-interest mailing list >> [hidden email] >> https://lists.sourceforge.net/lists/listinfo/joda-interest >> >> > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Joda-interest mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/joda-interest > ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
I have no fixed time-line for a release, so I'd recommend building
your own right now. Stephen On 24 June 2010 17:15, Ansgar Konermann <[hidden email]> wrote: > Hi Stephen, > > great! Thanks. > > Do you plan on making a release any time soon, or is it worth the effort > to build the source code on my own and deploy it into our company's > maven repo? > > Best regards > > Ansgar > > On 24.06.2010 12:21, Stephen Colebourne wrote: >> Please check the latest svn code. It should handle your requirement. >> Stephen >> >> On 23 June 2010 20:05, Ansgar Konermann<[hidden email]> wrote: >> >>> Hi all, >>> >>> I recently ran into the need to define a custom MillisProvider for test >>> purposes. >>> >>> Full explanation for this use case can be found here: >>> http://passion.forco.de/content/beware-now-equals-now-might-yield-false >>> >>> I have two wishes / feature requests: >>> - please make DateTimeUtils.MillisProvider a public interface >>> - add a method setMillisProvider, which allows to set a custom millis >>> povider implementation >>> >>> Any chances to see these features in one of the upcoming joda time >>> releases? I'd also be willing to help out with coding... >>> >>> Kind regards >>> >>> Ansgar Konermann >>> >>> ------------------------------------------------------------------------------ >>> ThinkGeek and WIRED's GeekDad team up for the Ultimate >>> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the >>> lucky parental unit. See the prize list and enter to win: >>> http://p.sf.net/sfu/thinkgeek-promo >>> _______________________________________________ >>> Joda-interest mailing list >>> [hidden email] >>> https://lists.sourceforge.net/lists/listinfo/joda-interest >>> >>> >> ------------------------------------------------------------------------------ >> ThinkGeek and WIRED's GeekDad team up for the Ultimate >> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the >> lucky parental unit. See the prize list and enter to win: >> http://p.sf.net/sfu/thinkgeek-promo >> _______________________________________________ >> Joda-interest mailing list >> [hidden email] >> https://lists.sourceforge.net/lists/listinfo/joda-interest >> > > > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Joda-interest mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/joda-interest > ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
Hi Stephen,
sorry to bother you again... :-) We're using Joda Time 1.6 in production code and we would really like to use the custom MillisProvider feature. Since the current trunk version obviously already resembles the 2.x development line, we are wondering if we can switch our production code to the trunk version without problems -- probably we cannot, or can we? We feel there might be serious risks, since 2.0 its a new major version. As a temporary solution, I'd be willing to backport the custom millis provider to the 1.6 development branch and maintain a specific version for my employer. Of course I'd preferr a solution which minimizes effort on all sides. Some questions regarding this: - is it correct that development of the 1.6 line takes place in the v1_6_000_BRANCH branch, located at https://joda-time.svn.sourceforge.net/svnroot/joda-time/branches/v1_6_000_BRANCH/ - if I provide you with a patch against 1.6.1, which backports custom millis provider from 2.0 to 1.6.1, would you basically be willing to apply this patch to the 1.6 development line? This could save us some effort for future updates in the 1.6.x development line: we wouldn't have to re-apply the patch and can simply use a version from maven cental instead of maintaining our own version of Joda Time containing the backport. Thanks for your patience... Kind regards Ansgar On 24.06.2010 18:37, Stephen Colebourne wrote: > I have no fixed time-line for a release, so I'd recommend building > your own right now. > Stephen > > On 24 June 2010 17:15, Ansgar Konermann<[hidden email]> wrote: > >> Hi Stephen, >> >> great! Thanks. >> >> Do you plan on making a release any time soon, or is it worth the effort >> to build the source code on my own and deploy it into our company's >> maven repo? >> >> Best regards >> >> Ansgar >> >> On 24.06.2010 12:21, Stephen Colebourne wrote: >> >>> Please check the latest svn code. It should handle your requirement. >>> Stephen >>> ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
Hi,
To keep Joda-Time stable, I only add bug fixes to minor versions. Thus any new 1.x version would need to be 1.7. The 2.x TRUNK in svn is entirely stable and awaiting release. It is effectively in QA at the moment. I am waiting for Joda-Convert to be available so I can add some annotations to Joda-Time before release. Therefore, if you build a 2.x you will find it completely unaltered from a code perspective when 2.0 is actually released. Note that the 2.x name simply refers to the fact that some deprecated methods were removed, and generics added. The 2.x jar file should be binary compatible and 99.9% source compatible with your existing code (see the release notes in svn). Hope that helps, Stephen On 24 August 2010 08:55, Ansgar Konermann <[hidden email]> wrote: > Hi Stephen, > > sorry to bother you again... :-) > > We're using Joda Time 1.6 in production code and we would really like to > use the custom MillisProvider feature. Since the current trunk version > obviously already resembles the 2.x development line, we are wondering > if we can switch our production code to the trunk version without > problems -- probably we cannot, or can we? We feel there might be > serious risks, since 2.0 its a new major version. > > As a temporary solution, I'd be willing to backport the custom millis > provider to the 1.6 development branch and maintain a specific version > for my employer. Of course I'd preferr a solution which minimizes effort > on all sides. Some questions regarding this: > > - is it correct that development of the 1.6 line takes place in the > v1_6_000_BRANCH branch, located at > https://joda-time.svn.sourceforge.net/svnroot/joda-time/branches/v1_6_000_BRANCH/ > > - if I provide you with a patch against 1.6.1, which backports custom > millis provider from 2.0 to 1.6.1, would you basically be willing to > apply this patch to the 1.6 development line? This could save us some > effort for future updates in the 1.6.x development line: we wouldn't > have to re-apply the patch and can simply use a version from maven > cental instead of maintaining our own version of Joda Time containing > the backport. > > Thanks for your patience... > > Kind regards > > Ansgar > > On 24.06.2010 18:37, Stephen Colebourne wrote: >> I have no fixed time-line for a release, so I'd recommend building >> your own right now. >> Stephen >> >> On 24 June 2010 17:15, Ansgar Konermann<[hidden email]> wrote: >> >>> Hi Stephen, >>> >>> great! Thanks. >>> >>> Do you plan on making a release any time soon, or is it worth the effort >>> to build the source code on my own and deploy it into our company's >>> maven repo? >>> >>> Best regards >>> >>> Ansgar >>> >>> On 24.06.2010 12:21, Stephen Colebourne wrote: >>> >>>> Please check the latest svn code. It should handle your requirement. >>>> Stephen >>>> > > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > Joda-interest mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/joda-interest > ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
Hi Stephen,
thanks for that prompt response. I tried to build the trunk, however a smaller number of tests fail (6 failures, 4 errors). Are there any tests which are "known to fail"? A quick peek into the test logs show they all seem to be related to formatting and locales. Since I'm on a machine with German locale, some day/month names differ from the expected values. Tests run: 3750, Failures: 6, Errors: 4, Skipped: 0, Time elapsed: 7.993 sec <<< FAILURE! Results : Failed tests: testToString_String_Locale(org.joda.time.TestLocalDateTime_Basics) testPropertyGetMonth(org.joda.time.TestLocalDateTime_Properties) testToString_String_Locale(org.joda.time.TestLocalDate_Basics) testPropertyGetMonth(org.joda.time.TestLocalDate_Properties) testPropertyGetMonth(org.joda.time.TestYearMonthDay_Properties) testPropertyGetMonth(org.joda.time.TestYearMonth_Properties) Tests in error: testPropertySetCopyTextMonth(org.joda.time.TestLocalDateTime_Properties) testPropertySetCopyTextMonth(org.joda.time.TestLocalDate_Properties) testPropertySetTextMonth(org.joda.time.TestYearMonthDay_Properties) testPropertySetTextMonth(org.joda.time.TestYearMonth_Properties) Tests run: 3750, Failures: 6, Errors: 4, Skipped: 0 How should we proceed from here? I can send the complete testsuite log file (400k) if you like? Regards Ansgar On 24.08.2010 10:47, Stephen Colebourne wrote: > Hi, > To keep Joda-Time stable, I only add bug fixes to minor versions. Thus > any new 1.x version would need to be 1.7. > > The 2.x TRUNK in svn is entirely stable and awaiting release. It is > effectively in QA at the moment. I am waiting for Joda-Convert to be > available so I can add some annotations to Joda-Time before release. > > Therefore, if you build a 2.x you will find it completely unaltered > from a code perspective when 2.0 is actually released. Note that the > 2.x name simply refers to the fact that some deprecated methods were > removed, and generics added. The 2.x jar file should be binary > compatible and 99.9% source compatible with your existing code (see > the release notes in svn). > > Hope that helps, > Stephen > ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
Thats Bad. All the locale cases should be dealt with by a
setup/teardown of the locale, or try finally. If you want to save me some time, you're welcome to look at the source code and figure out whats up. The locale part is working in a lot of other places. I don't expect to be able to fix this myself immediately. Stephen On 24 August 2010 11:37, Ansgar Konermann <[hidden email]> wrote: > Hi Stephen, > > thanks for that prompt response. I tried to build the trunk, however a > smaller number of tests fail (6 failures, 4 errors). > > Are there any tests which are "known to fail"? > > A quick peek into the test logs show they all seem to be related to > formatting and locales. Since I'm on a machine with German locale, some > day/month names differ from the expected values. > > > Tests run: 3750, Failures: 6, Errors: 4, Skipped: 0, Time elapsed: 7.993 > sec <<< FAILURE! > > Results : > > Failed tests: > testToString_String_Locale(org.joda.time.TestLocalDateTime_Basics) > testPropertyGetMonth(org.joda.time.TestLocalDateTime_Properties) > testToString_String_Locale(org.joda.time.TestLocalDate_Basics) > testPropertyGetMonth(org.joda.time.TestLocalDate_Properties) > testPropertyGetMonth(org.joda.time.TestYearMonthDay_Properties) > testPropertyGetMonth(org.joda.time.TestYearMonth_Properties) > > Tests in error: > testPropertySetCopyTextMonth(org.joda.time.TestLocalDateTime_Properties) > testPropertySetCopyTextMonth(org.joda.time.TestLocalDate_Properties) > testPropertySetTextMonth(org.joda.time.TestYearMonthDay_Properties) > testPropertySetTextMonth(org.joda.time.TestYearMonth_Properties) > > Tests run: 3750, Failures: 6, Errors: 4, Skipped: 0 > > How should we proceed from here? I can send the complete testsuite log > file (400k) if you like? > > Regards > > Ansgar > > On 24.08.2010 10:47, Stephen Colebourne wrote: >> Hi, >> To keep Joda-Time stable, I only add bug fixes to minor versions. Thus >> any new 1.x version would need to be 1.7. >> >> The 2.x TRUNK in svn is entirely stable and awaiting release. It is >> effectively in QA at the moment. I am waiting for Joda-Convert to be >> available so I can add some annotations to Joda-Time before release. >> >> Therefore, if you build a 2.x you will find it completely unaltered >> from a code perspective when 2.0 is actually released. Note that the >> 2.x name simply refers to the fact that some deprecated methods were >> removed, and generics added. The 2.x jar file should be binary >> compatible and 99.9% source compatible with your existing code (see >> the release notes in svn). >> >> Hope that helps, >> Stephen >> > > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > Joda-interest mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/joda-interest > ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
On 24.08.2010 12:41, Stephen Colebourne wrote:
> Thats Bad. All the locale cases should be dealt with by a > setup/teardown of the locale, or try finally. > > If you want to save me some time, you're welcome to look at the source > code and figure out whats up. The locale part is working in a lot of > other places. I don't expect to be able to fix this myself > immediately. > > Stephen > after digging into the code, it wasn't all that bad. Some tests assumed the system's default locale to be set to english, as they pass "null" as the locale to some formatting routines. I fixed these spots. Find a small patch attached. Do you have a few minutes of spare time to apply this to the trunk? Best regards Ansgar ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
|
I've applied your patch, hopefully svn should run tests for you now.
thanks Stephen On 24 August 2010 18:17, Ansgar Konermann <[hidden email]> wrote: > On 24.08.2010 12:41, Stephen Colebourne wrote: >> >> Thats Bad. All the locale cases should be dealt with by a >> setup/teardown of the locale, or try finally. >> >> If you want to save me some time, you're welcome to look at the source >> code and figure out whats up. The locale part is working in a lot of >> other places. I don't expect to be able to fix this myself >> immediately. >> >> Stephen >> > > Hi Stephen, > > after digging into the code, it wasn't all that bad. > > Some tests assumed the system's default locale to be set to english, as they > pass "null" as the locale to some formatting routines. I fixed these spots. > Find a small patch attached. > > Do you have a few minutes of spare time to apply this to the trunk? > > Best regards > > Ansgar > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > Joda-interest mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/joda-interest > > ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Joda-interest mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/joda-interest |
| Powered by Nabble | See how NAML generates this page |
